js8544 commented on PR #36906: URL: https://github.com/apache/arrow/pull/36906#issuecomment-1671514678
> We don't, but would it improve anything to use different indices for each child? Judging from https://github.com/apache/arrow/blob/main/cpp/src/arrow/compute/kernels/vector_selection_take_internal.cc#L369, we can make the unneeded indices the same as the needed ones, so that accessing `values_data[indices_data[position]]` is more cache friendly. But I agree that this is very subtle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
