paleolimbot commented on code in PR #36436:
URL: https://github.com/apache/arrow/pull/36436#discussion_r1288674515
##########
r/R/csv.R:
##########
@@ -510,32 +510,55 @@ CsvReadOptions$create <- function(use_threads =
option_use_threads(),
options
}
-readr_to_csv_write_options <- function(include_header = TRUE,
+readr_to_csv_write_options <- function(col_names = TRUE,
batch_size = 1024L,
- na = "") {
+ delim = ",",
+ na = "",
+ eol = "\n",
+ quote = "Needed") {
Review Comment:
My take is that if Arrow can't produce identical behaviour (or if we don't
have the bandwidth to implement tests for identical behaviour), the readr value
shouldn't be accepted (any of us could open a follow-up ticket to request that
feature from Arrow C++ developers if it turns out to be important). It sounds
like @dgreiss' solution of using the UpperCamelCase version is reasonable...if
a user does attempt to `write_csv_arrow(..., quote = "needed")`, they will get
an error and can refer to the documentation about accepted values and how they
may differ from readr behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
