nealrichardson commented on code in PR #36436:
URL: https://github.com/apache/arrow/pull/36436#discussion_r1288795228
##########
r/R/csv.R:
##########
@@ -510,32 +510,55 @@ CsvReadOptions$create <- function(use_threads =
option_use_threads(),
options
}
-readr_to_csv_write_options <- function(include_header = TRUE,
+readr_to_csv_write_options <- function(col_names = TRUE,
batch_size = 1024L,
- na = "") {
+ delim = ",",
+ na = "",
+ eol = "\n",
+ quote = "Needed") {
Review Comment:
IMO I'd check whether "needed" really is different from the readr
behavior--it's not obvious to me from the enum docstring that it is. If it is
subtly different, I'd document it in the function and leave it at that.
Otherwise it seems that the Arrow options are morally equivalent to the readr
ones and it makes sense to map them to each other, documenting any behavior
differences, as we do for the Acero function mappings.
I think the difference between `"Needed"` vs `"needed"` is too subtle to
switch behaviors on. And I can't think of where we have a precedent for doing
that in the package, but maybe I'm missing something obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
