tustvold commented on code in PR #4670:
URL: https://github.com/apache/arrow-rs/pull/4670#discussion_r1288817678
##########
arrow-data/src/equal/fixed_binary.rs:
##########
@@ -80,7 +80,7 @@ pub(super) fn fixed_binary_equal(
lhs_start + lhs_nulls.offset(),
len,
);
- let rhs_nulls = lhs.nulls().unwrap();
+ let rhs_nulls = rhs.nulls().unwrap();
Review Comment:
It is actually remarkably hard to construct a test case to exercise this,
kudos to @kawadakk for finding one. The reason it is hard is at this point the
null masks have already been checked for equality, so you need one side to have
a different start offset from the other, such that when correctly offset the
null buffers compare equal, but the underlying null buffers themselves are not
actually equal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
