paleolimbot commented on issue #37091:
URL: https://github.com/apache/arrow/issues/37091#issuecomment-1671759369
Hmm...when I build Arrow off of the PR branch I get
```
✖ | 5 389 | data-type
────────────────────────────────────────────────────────────────────────────────────────────────────
Failure (test-data-type.R:292:3): duration types work as expected
`object` (`actual`) not equal to `expected` (`expected`).
`actual`: 34
`expected`: 33
Backtrace:
▆
1. └─arrow:::expect_equal(x$id, Type$DURATION) at test-data-type.R:292:2
2. └─testthat::expect_equal(...) at
tests/testthat/helper-expectation.R:43:4
Failure (test-data-type.R:303:3): duration types work as expected
`object` (`actual`) not equal to `expected` (`expected`).
`actual`: 34
`expected`: 33
Backtrace:
▆
1. └─arrow:::expect_equal(x$id, Type$DURATION) at test-data-type.R:303:2
2. └─testthat::expect_equal(...) at
tests/testthat/helper-expectation.R:43:4
Failure (test-data-type.R:380:3): map type works as expected
`object` (`actual`) not equal to `expected` (`expected`).
`actual`: 31
`expected`: 30
Backtrace:
▆
1. └─arrow:::expect_equal(x$id, Type$MAP) at test-data-type.R:380:2
2. └─testthat::expect_equal(...) at
tests/testthat/helper-expectation.R:43:4
Failure (test-data-type.R:430:3): struct type works as expected
`object` (`actual`) not equal to `expected` (`expected`).
`actual`: 27
`expected`: 26
Backtrace:
▆
1. └─arrow:::expect_equal(x$id, Type$STRUCT) at test-data-type.R:430:2
2. └─testthat::expect_equal(...) at
tests/testthat/helper-expectation.R:43:4
Failure (test-data-type.R:458:3): DictionaryType works as expected
(ARROW-3355)
`object` (`actual`) not equal to `expected` (`expected`).
`actual`: 30
`expected`: 29
Backtrace:
▆
1. └─arrow:::expect_equal(d$id, Type$DICTIONARY) at test-data-type.R:458:2
2. └─testthat::expect_equal(...) at
tests/testthat/helper-expectation.R:43:4
```
...so I wonder if the type enum IDs changed and need to be synced with
https://github.com/apache/arrow/blob/7c8f398f32ba5d2685093a010002f729a01a4242/r/R/enums.R#L44-L82
I'm not exactly sure how the wrong type ID would end up there, but if the
wrong type ID was at
https://github.com/apache/arrow/blob/d3ccc833a61b70a988090cd8065d3e38d7c29a89/r/src/scalar.cpp#L60-L63
...it would crash because casting an extension array to utf-8 is not
implemented (this was the error that https://github.com/apache/arrow/pull/15277
fixed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
