tustvold commented on code in PR #4671:
URL: https://github.com/apache/arrow-rs/pull/4671#discussion_r1288866927
##########
.github/workflows/rust.yml:
##########
@@ -121,6 +121,10 @@ jobs:
- name: Check arrow-flight
working-directory: arrow-flight
run: cargo msrv verify
+ - name: Downgrade object_store dependencies
+ working-directory: object_store
+ # Necessary because 1.30.0 updates MSRV to 1.63
+ run: cargo update -p tokio --precise 1.29.1
Review Comment:
Other options would be to:
* Add a maximum version constraint
* Check in a lockfile
But both of these have obvious drawbacks, this seemed relatively
unintrusive. Hopefully at some point cargo will add MSRV aware resolution so
these sort of shenanigans will be handled automatically -
https://github.com/rust-lang/cargo/issues/9930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
