jhorstmann commented on a change in pull request #8975:
URL: https://github.com/apache/arrow/pull/8975#discussion_r550272926
##########
File path: rust/arrow/src/array/array_primitive.rs
##########
@@ -67,19 +67,6 @@ impl<T: ArrowPrimitiveType> PrimitiveArray<T> {
self.data.is_empty()
}
- /// Returns a slice for the given offset and length
Review comment:
My rationale was that this would have already been removed as part of
ARROW-10989, if not for this one usage in the comparison kernels. The
straight-forward replacement would be `values()[offset..offset+len]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
