indigophox commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1289293824
########## cpp/src/arrow/flight/sql/types.h: ########## Review Comment: Debatable, I leaned towards "we're already not exposing the ser/des stuff in Flight so why pollute it with enums and so on that don't pertain to anything, when anyone implementing handlers for these has to touch the Proto types anyways". If you really want they can be moved but I do think it adds orphaned bits of noisy stuff to Flight without them being tied to anything in the Flight component of the package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
