lidavidm commented on code in PR #34817: URL: https://github.com/apache/arrow/pull/34817#discussion_r1289333363
########## cpp/src/arrow/flight/sql/protocol_internal.h: ########## @@ -24,3 +24,4 @@ #include "arrow/flight/sql/visibility.h" #include "arrow/flight/sql/FlightSql.pb.h" // IWYU pragma: export +#include "arrow/flight/Flight.pb.h" Review Comment: Basically: you cannot expose any Protobuf types in an Arrow API, implicitly or explicitly. All Protobuf messages need to have an equivalent, pure-C++ definition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
