aiguofer commented on code in PR #37085:
URL: https://github.com/apache/arrow/pull/37085#discussion_r1289521426
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/JdbcToArrowConfig.java:
##########
@@ -338,4 +356,18 @@ public Map<Integer, Map<String, String>>
getColumnMetadataByColumnIndex() {
public RoundingMode getBigDecimalRoundingMode() {
return bigDecimalRoundingMode;
}
+
+ /**
+ * Interface for a function with 4 parameters.
+ *
+ * @param <A> param 1 type
+ * @param <B> param 2 type
+ * @param <C> param 3 type
+ * @param <D> param 4 type
+ * @param <R> return type
+ */
+ @FunctionalInterface
+ interface Function4Arity<A, B, C, D, R> {
Review Comment:
done! Though I realized that most implementations will likely also need the
config itself as one of the parameters... bit of a chicken and egg problem. You
don't have the config yet when building the config -.-
I'm thinking there might be some way to do this but I'm not familiar enough
with java to think of a good solution. I imagine some sort of wrapper or
abstract class that injects the instance of the config when `apply` is called
but I'm not exactly sure what this would look like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
