thisisnic commented on code in PR #37024:
URL: https://github.com/apache/arrow/pull/37024#discussion_r1289906449
##########
r/R/io.R:
##########
@@ -250,15 +250,8 @@ make_readable_file <- function(file, mmap = TRUE,
random_access = TRUE) {
}
if (is_url(file)) {
- file <- tryCatch(
- {
- fs_and_path <- FileSystem$from_uri(file)
- fs_and_path$fs$OpenInputFile(fs_and_path$path)
- },
- error = function(e) {
- MakeRConnectionInputStream(url(file, open = "rb"))
- }
- )
+ fs_and_path <- FileSystem$from_uri(file)
+ file <- fs_and_path$fs$OpenInputFile(fs_and_path$path)
Review Comment:
I don't mind updating the PR, as your explanation of what is needed makes it
pretty clear to me - thanks! Will come back to this next week as I have a few
other things higher on my to-do list for this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
