pitrou commented on code in PR #37101:
URL: https://github.com/apache/arrow/pull/37101#discussion_r1290268738
##########
cpp/src/arrow/type.cc:
##########
@@ -779,22 +778,20 @@ std::string UnionType::ToString() const {
return s.str();
}
-SparseUnionType::SparseUnionType(std::vector<std::shared_ptr<Field>> fields,
- std::vector<int8_t> type_codes)
+SparseUnionType::SparseUnionType(FieldVector fields, std::vector<int8_t>
type_codes)
: UnionType(fields, type_codes, Type::SPARSE_UNION) {}
-Result<std::shared_ptr<DataType>> SparseUnionType::Make(
- std::vector<std::shared_ptr<Field>> fields, std::vector<int8_t>
type_codes) {
+Result<std::shared_ptr<DataType>> SparseUnionType::Make(FieldVector fields,
+ std::vector<int8_t>
type_codes) {
RETURN_NOT_OK(ValidateParameters(fields, type_codes, UnionMode::SPARSE));
return std::make_shared<SparseUnionType>(fields, type_codes);
}
-DenseUnionType::DenseUnionType(std::vector<std::shared_ptr<Field>> fields,
- std::vector<int8_t> type_codes)
+DenseUnionType::DenseUnionType(FieldVector fields, std::vector<int8_t>
type_codes)
: UnionType(fields, type_codes, Type::DENSE_UNION) {}
Review Comment:
Same here: can move.
##########
cpp/src/arrow/type.cc:
##########
@@ -779,22 +778,20 @@ std::string UnionType::ToString() const {
return s.str();
}
-SparseUnionType::SparseUnionType(std::vector<std::shared_ptr<Field>> fields,
- std::vector<int8_t> type_codes)
+SparseUnionType::SparseUnionType(FieldVector fields, std::vector<int8_t>
type_codes)
: UnionType(fields, type_codes, Type::SPARSE_UNION) {}
Review Comment:
Can move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
