lidavidm commented on code in PR #964:
URL: https://github.com/apache/arrow-adbc/pull/964#discussion_r1290445086
##########
c/driver/postgresql/statement.cc:
##########
@@ -679,23 +660,19 @@ int TupleReader::GetNext(struct ArrowArray* out) {
return EIO;
}
- ResetQuery();
ArrowArrayMove(&tmp, out);
return NANOARROW_OK;
}
void TupleReader::Release() {
StringBuilderReset(&error_builder_);
- if (result_) {
- PQclear(result_);
- result_ = nullptr;
+ if (copy_reader_) {
+ copy_reader_.reset();
}
- if (pgbuf_) {
- PQfreemem(pgbuf_);
- pgbuf_ = nullptr;
- }
Review Comment:
Wait, but we still need to free the other state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
