zeroshade commented on code in PR #37112:
URL: https://github.com/apache/arrow/pull/37112#discussion_r1290506116
##########
go/parquet/internal/utils/bit_writer.go:
##########
@@ -81,11 +81,15 @@ func NewBitWriter(w io.WriterAt) *BitWriter {
// ReserveBytes reserves the next aligned nbytes, skipping them and returning
// the offset to use with WriteAt to write to those reserved bytes. Used for
// RLE encoding to fill in the indicators after encoding.
-func (b *BitWriter) ReserveBytes(nbytes int) int {
+func (b *BitWriter) ReserveBytes(nbytes int) (int, error) {
b.Flush(true)
ret := b.byteoffset
b.byteoffset += nbytes
- return ret
+ if _, err := b.wr.WriteAt(b.raw[:nbytes], int64(ret)); err != nil {
+ log.Println(err)
+ return 0, err
+ }
Review Comment:
Instead of doing this would it make more sense to expand the `io.WriterAt`
interface we're using to be something more like
```go
type writer interface {
io.WriterAt
Reserve(nbytes int)
}
```
so that the `ReserveBytes` method here could just be
```go
b.Flush(true)
ret := b.byteoffset
b.byteoffset += nbytes
b.wr.Reserve(nbytes)
return ret
```
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
