tustvold commented on code in PR #4681:
URL: https://github.com/apache/arrow-rs/pull/4681#discussion_r1291229377
##########
arrow/tests/array_validation.rs:
##########
@@ -56,7 +56,9 @@ fn test_bad_number_of_buffers() {
}
#[test]
-#[should_panic(expected = "integer overflow computing min buffer size")]
+#[should_panic(
+ expected = "Need at least 18446744073709551615 bytes in buffers[0] in
array of type Int64, but got 8"
Review Comment:
As an allocation cannot be larger than isize, we might as well just saturate
at usize::MAX, we're going to fail anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
