alamb commented on code in PR #4684: URL: https://github.com/apache/arrow-rs/pull/4684#discussion_r1291241839
########## object_store/src/aws/copy.rs: ########## @@ -17,7 +17,10 @@ use crate::config::Parse; -/// Configure how to provide [`ObjectStore::copy_if_not_exists`] for [`AmazonS3`] Review Comment: Rather than trying to actually make the link to [`AmazonS3`] work by conditionalizing the docs with the "grim" approach @tustvold describes in https://github.com/apache/arrow-rs/issues/4683#issuecomment-1674584324 I opted to simply avoid the link, which I think is reasonable given this is in the `aws` module and has `S3` in the name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
