devinjdangelo commented on code in PR #7244:
URL: https://github.com/apache/arrow-datafusion/pull/7244#discussion_r1291302106
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -448,8 +448,10 @@ async fn test_substring_expr() -> Result<()> {
Ok(())
}
+/// Test string expressions test split into two batches
Review Comment:
Flagging this as it is a bit strange. This test was generating a
stackoverflow error consistently until I split it into two batches. I have
added a good number of config options to the SessionContext, which I suppose
has grown the amount of bytes we are storing on the stack for each
SessionContext.
Is there a larger concern here that as we add more config options, we are
filling up the stack? I think probably not as it seems this test is creating a
very large number of SessionContexts all at once. Perhaps that is not an
unusual usecase downstream though 🤔. A single thread on a server responding to
many concurrent requests may create many SessionContexts one for each async
task and hit a stackoverflow?
##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -448,8 +448,10 @@ async fn test_substring_expr() -> Result<()> {
Ok(())
}
+/// Test string expressions test split into two batches
Review Comment:
Flagging this as it is a bit strange. This test was generating a
stackoverflow error consistently until I split it into two batches. I have
added a good number of config options to the SessionContext, which I suppose
has grown the amount of bytes we are storing on the stack for each
SessionContext.
Is there a larger concern here that as we add more config options, we are
filling up the stack? I think probably not as it seems this test is creating a
very large number of SessionContexts all at once. Perhaps that is not an
unusual usecase downstream though 🤔. A single thread on a server responding to
many concurrent requests may create many SessionContexts one for each async
task and hit a stackoverflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
