danepitkin commented on code in PR #37125:
URL: https://github.com/apache/arrow/pull/37125#discussion_r1291655238
##########
java/flight/flight-sql-jdbc-core/src/test/java/org/apache/arrow/driver/jdbc/client/utils/ClientAuthenticationUtilsTest.java:
##########
@@ -169,13 +169,15 @@ private MockedStatic<ClientAuthenticationUtils>
createClientAuthenticationUtilsS
if (method.getName().equals("getCertificateInputStreamFromSystem")) {
return invocationOnMock.callRealMethod();
}
- return invocationOnMock.getMock();
+ return method.invoke(invocationOnMock.getMock(),
invocationOnMock.getArguments());
});
}
private void setOperatingSystemMock(MockedStatic<ClientAuthenticationUtils>
clientAuthenticationUtilsMockedStatic,
boolean isWindows, boolean isMac) {
clientAuthenticationUtilsMockedStatic.when(ClientAuthenticationUtils::isMac).thenReturn(isMac);
+ Assert.assertEquals(ClientAuthenticationUtils.isMac(), isMac);
Review Comment:
I can leave this out of the final diff if requested, but I think having this
check could have caught the test suite bug in prior versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
