R-JunmingChen commented on code in PR #37100:
URL: https://github.com/apache/arrow/pull/37100#discussion_r1291926801
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -873,6 +888,13 @@ Result<TypeHolder> MinMaxType(KernelContext*, const
std::vector<TypeHolder>& typ
return struct_({field("min", ty), field("max", ty)});
}
+Result<TypeHolder> DictionaryMinMaxType(KernelContext*, const
std::vector<TypeHolder>& types) {
+ // T -> struct<min: T.value_type, max: T.value_type>
+ auto ty = types.front().GetSharedPtr();
Review Comment:
Sure, have updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
