alamb commented on code in PR #4677:
URL: https://github.com/apache/arrow-rs/pull/4677#discussion_r1293277429


##########
object_store/src/memory.rs:
##########
@@ -43,11 +45,13 @@ enum Error {
     #[snafu(display("No data in memory found. Location: {path}"))]
     NoDataInMemory { path: String },
 
-    #[snafu(display("Out of range"))]
-    OutOfRange,
+    #[snafu(display(
+        "Requested range {}..{} is out of bounds for object with length {}", 
range.start, range.end, len
+    ))]
+    OutOfRange { range: Range<usize>, len: usize },

Review Comment:
   ❤️ 



##########
object_store/src/memory.rs:
##########
@@ -43,11 +45,13 @@ enum Error {
     #[snafu(display("No data in memory found. Location: {path}"))]
     NoDataInMemory { path: String },
 
-    #[snafu(display("Out of range"))]
-    OutOfRange,
+    #[snafu(display(
+        "Requested range {}..{} is out of bounds for object with length {}", 
range.start, range.end, len
+    ))]
+    OutOfRange { range: Range<usize>, len: usize },

Review Comment:
   ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to