otegami commented on code in PR #37137:
URL: https://github.com/apache/arrow/pull/37137#discussion_r1293391484
##########
ruby/red-arrow/ext/arrow/raw-records.cpp:
##########
@@ -26,7 +26,9 @@ namespace red_arrow {
explicit RawRecordsBuilder(VALUE records, int n_columns)
: Converter(),
records_(records),
- n_columns_(n_columns) {
+ record_(Qnil),
+ n_columns_(n_columns),
+ is_produce_mode_(false) {
Review Comment:
fix:
[3318abc](https://github.com/apache/arrow/pull/37137/commits/3318abc8aa4e7d9e82da61a6b779d7556d97bee6)
Sounds pretty nice to me!
I tried to split `RawRecordProducer` into its own source file because some
methods had to know the row-wise processing situation.
What do you think of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
