kevingurney commented on code in PR #37162:
URL: https://github.com/apache/arrow/pull/37162#discussion_r1293957106
##########
matlab/src/matlab/+arrow/+tabular/Schema.m:
##########
@@ -43,17 +43,22 @@
end
function F = field(obj, idx)
- idx = convertCharsToStrings(idx);
- if ~isempty(idx) && isscalar(idx) && isnumeric(idx) && idx >= 1
- args = struct(Index=int32(idx));
+ import arrow.internal.validate.*
+
+ idx = index.numericOrString(idx, "int32");
+
+ if isnumeric(idx)
+ % TODO: Consider vectorizing field() to support extracting
Review Comment:
Could you create an issue for adding support for vectorized indexing? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
