sunchao commented on a change in pull request #9047:
URL: https://github.com/apache/arrow/pull/9047#discussion_r550576451
##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -657,6 +645,22 @@ impl ParquetTypeConverter<'_> {
}
}
+ fn to_decimal(&self) -> Result<DataType> {
+ let (precision, scale) = match self.schema {
+ Type::PrimitiveType {
+ ref precision,
+ ref scale,
+ ..
+ } => (*precision, *scale),
+ _ => {
+ return Err(ArrowError(
Review comment:
I'm thinking something like:
```rust
assert!(self.schema.is_primitive());
if let ... {
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
