felipecrv commented on issue #37153: URL: https://github.com/apache/arrow/issues/37153#issuecomment-1678192859
My concern is that the inheritance chain and type-based dispatching introduce another layer of indirection in compute kernel code that hinders readability. Considering that kernel code is directly concerned with the dispatching of function calls based on types, time units, validity bitmaps, using single functions that can handle multiple types, adding another layer of function call dispatching would make the code harder to reason about IMO. I'm not saying the kernel code is easy as it is now, but I would rather improve it in the dispatching paradigm it has started with than tilt it towards the type-based call dispatching paradigm (one function per type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
