alamb commented on code in PR #7268:
URL: https://github.com/apache/arrow-datafusion/pull/7268#discussion_r1294651100
##########
datafusion/sql/src/statement.rs:
##########
@@ -95,11 +95,22 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Generate a logical plan from an SQL statement
pub fn sql_statement_to_plan(&self, statement: Statement) ->
Result<LogicalPlan> {
- self.sql_statement_to_plan_with_context(statement, &mut
PlannerContext::new())
+ self.sql_statement_to_plan_with_context_impl(
+ statement,
+ &mut PlannerContext::new(),
+ )
}
/// Generate a logical plan from an SQL statement
- fn sql_statement_to_plan_with_context(
+ pub fn sql_statement_to_plan_with_context(
Review Comment:
👍 I think this PR could be merged in as is. @waynexia feel free to merge
it (or let us know you plan to make more changes)
##########
datafusion/sql/src/statement.rs:
##########
@@ -95,11 +95,22 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Generate a logical plan from an SQL statement
pub fn sql_statement_to_plan(&self, statement: Statement) ->
Result<LogicalPlan> {
- self.sql_statement_to_plan_with_context(statement, &mut
PlannerContext::new())
+ self.sql_statement_to_plan_with_context_impl(
+ statement,
+ &mut PlannerContext::new(),
+ )
}
/// Generate a logical plan from an SQL statement
- fn sql_statement_to_plan_with_context(
+ pub fn sql_statement_to_plan_with_context(
Review Comment:
👍 I think this PR could be merged in as is. @waynexia feel free to merge
it (or let us know you plan to make more changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
