nevi-me commented on a change in pull request #9054:
URL: https://github.com/apache/arrow/pull/9054#discussion_r550738792
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -624,10 +650,10 @@ mod tests {
}
// case with nulls is tested in the docs, through the example on this
module.
- #[test]
- fn test_string() -> Result<()> {
+ fn test_genetic_string<Offset: StringOffsetSizeTrait>() -> Result<()> {
Review comment:
```suggestion
fn test_generic_string<Offset: StringOffsetSizeTrait>() -> Result<()> {
```
##########
File path: rust/arrow/src/ffi.rs
##########
@@ -654,4 +683,40 @@ mod tests {
// (drop/release)
Ok(())
}
+
+ #[test]
+ fn test_string() -> Result<()> {
+ test_genetic_string::<i32>()
+ }
+
+ #[test]
+ fn test_large_string() -> Result<()> {
+ test_genetic_string::<i64>()
+ }
+
+ #[test]
+ fn test_bool() -> Result<()> {
Review comment:
nice and neat :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
