sgilmore10 opened a new pull request, #37185:
URL: https://github.com/apache/arrow/pull/37185
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Now that `featherread` and `featherwrite` have been re-implemented in terms
of the new APIs (`matlab.internal.io.feather.Reader` in #37046 and
`matlab.io.internal.feather.Writer` in #37045), we can start removing the MEX
code. To avoid submitting a large pull request, we should submit multiple small
pull requests. The first one should be delete the outdated test class
`tArrowCppCall.m`. This test class will no longer be relevant once the MEX
source code is removed.
### What changes are included in this PR?
1. Deleted the outdated test class `tArrowCppCall.m`
### Are these changes tested?
No tests necessary.
### Are there any user-facing changes?
No.
### Future Directions
1. Move the test cases in `test/tfeathermex.m` to
`test/arrow/internal/io/feather/tRoundtrip.m`. These test cases directly call
the MEX functions, so we will re-write the tests to utilize the
`arrow.internal.io.feather.Reader` and `arrow.internal.io.feather.Writer`
classes directly.
2. Delete `test/arrow/util/createVariablesAndMetadataStruct.m`
3. Delete `test/arrow/util/createTable.m`
4. Delete `test/arrow/util/featherMEXRoundTrip.m`
5. Delete `test/arrow/util/featherRoundTrip.m`
6. Remove MEX source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
