alamb commented on code in PR #4260:
URL: https://github.com/apache/arrow-rs/pull/4260#discussion_r1295797628
##########
arrow-buffer/Cargo.toml:
##########
@@ -34,6 +34,7 @@ path = "src/lib.rs"
bench = false
[dependencies]
+bytes = { version = "1.4" }
Review Comment:
https://crates.io/crates/bytes/reverse_dependencies -- crates.io agrees with
you ✅
If it causes problems for anyone, we could also put it behind a feature
flag, but perhaps we can wait to see if anyone needs that before doing it
##########
arrow-flight/src/decode.rs:
##########
@@ -258,7 +259,7 @@ impl FlightDataDecoder {
));
};
- let buffer: arrow_buffer::Buffer = data.data_body.into();
+ let buffer = Buffer::from_bytes(data.data_body.into());
Review Comment:
👍 I think we can use this API in IOx as well, FWIW.
##########
arrow-flight/src/decode.rs:
##########
@@ -258,7 +259,7 @@ impl FlightDataDecoder {
));
};
- let buffer: arrow_buffer::Buffer = data.data_body.into();
+ let buffer = Buffer::from_bytes(data.data_body.into());
Review Comment:
👍 I think we can use this API in IOx as well, FWIW.
##########
arrow-buffer/Cargo.toml:
##########
@@ -34,6 +34,7 @@ path = "src/lib.rs"
bench = false
[dependencies]
+bytes = { version = "1.4" }
Review Comment:
https://crates.io/crates/bytes/reverse_dependencies -- crates.io agrees with
you ✅
If it causes problems for anyone, we could also put it behind a feature
flag, but perhaps we can wait to see if anyone needs that before doing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
