pitrou commented on code in PR #37097:
URL: https://github.com/apache/arrow/pull/37097#discussion_r1295842877
##########
python/pyarrow/_substrait.pyx:
##########
@@ -28,7 +28,7 @@ from pyarrow.includes.libarrow_substrait cimport *
cdef CDeclaration _create_named_table_provider(
dict named_args, const std_vector[c_string]& names, const CSchema& schema
-):
+) noexcept:
Review Comment:
Are we sure this function cannot raise a Python exception? Its code is
definitely non-trivial, so the "solution" here looks more like a bandaid.
In the interest of moving this forward, can you open a bug for this and
we'll revisit later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
