tustvold commented on code in PR #4707:
URL: https://github.com/apache/arrow-rs/pull/4707#discussion_r1296120434
##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -460,21 +461,18 @@ impl<K: ArrowDictionaryKeyType> DictionaryArray<K> {
/// }
/// ```
///
- pub fn with_values(&self, values: &dyn Array) -> Self {
+ pub fn with_values(&self, values: ArrayRef) -> Self {
Review Comment:
This is a breaking change, and makes this API consistent with the other
constructors and avoids needing to go via ArrayData
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
