felipecrv commented on code in PR #37174: URL: https://github.com/apache/arrow/pull/37174#discussion_r1296188461
########## cpp/src/arrow/c/bridge_test.cc: ########## @@ -31,6 +31,7 @@ #include "arrow/c/bridge.h" #include "arrow/c/helpers.h" #include "arrow/c/util_internal.h" +#include "arrow/compute/api_vector.h" Review Comment: `RunEndEncode` and decode are considered one of the basic kernels that don't need the full arrow-compute build to be available as they are so integral to doing anything with REEs. > ...would take separate strings for run ends and values. That makes writing these tests so much harder and the code less readable. Can I create an issue about this to be fixed outside the context of this PR? I could make `RunEndEncode` usable without the entirety of `api_vector.h` --- as a C++ API utility function that is shared between the compute kernel and internal code like the test utilities? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
