alamb commented on code in PR #7300:
URL: https://github.com/apache/arrow-datafusion/pull/7300#discussion_r1296237845


##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1298,6 +1298,96 @@ async fn unnest_aggregate_columns() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn unnest_array_agg() -> Result<()> {

Review Comment:
   I verified that this test covers the code in this PR by running it without 
the code changes locally. It fails as expected 💯 
   
   ```
   
   ---- dataframe::unnest_array_agg stdout ----
   Error: ArrowError(ComputeError("concat requires input of at least one 
array"))
   
   ```



##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1298,6 +1298,96 @@ async fn unnest_aggregate_columns() -> Result<()> {
     Ok(())
 }
 
+#[tokio::test]
+async fn unnest_array_agg() -> Result<()> {

Review Comment:
   I verified that this test covers the code in this PR by running it without 
the code changes locally. It fails as expected 💯 
   
   ```
   
   ---- dataframe::unnest_array_agg stdout ----
   Error: ArrowError(ComputeError("concat requires input of at least one 
array"))
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to