izveigor commented on code in PR #7313:
URL: https://github.com/apache/arrow-datafusion/pull/7313#discussion_r1297427261
##########
datafusion/proto/src/logical_plan/from_proto.rs:
##########
@@ -452,6 +452,7 @@ impl From<&protobuf::ScalarFunction> for
BuiltinScalarFunction {
ScalarFunction::ToTimestamp => Self::ToTimestamp,
ScalarFunction::ArrayAppend => Self::ArrayAppend,
ScalarFunction::ArrayConcat => Self::ArrayConcat,
+ ScalarFunction::ArrayEmpty => Self::ArrayEmpty,
Review Comment:
`ArrayEmpty` does not present in the function `parse_expr`:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/proto/src/logical_plan/from_proto.rs#L911.
(See the example:
https://github.com/apache/arrow-datafusion/blob/main/datafusion/proto/src/logical_plan/from_proto.rs#L1358-#L1360)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
