alamb commented on a change in pull request #9038:
URL: https://github.com/apache/arrow/pull/9038#discussion_r550763046
##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
/// List of expressions to feed to the functions as arguments
args: Vec<Expr>,
},
+ /// Returns whether the list contains the expr value.
+ InList {
+ /// The value to compare
+ expr: Box<Expr>,
+ /// The low end of the range
+ list: Vec<Expr>,
+ /// Whether the expression is negated
+ negated: bool,
Review comment:
I can't remember exactly, but I think there might be some semantic
difference (regarding NULLs, of course) in SQL between `c NOT IN (..)` and `NOT
c IN (....)` FWIW that might require representing them differnetly
##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
/// List of expressions to feed to the functions as arguments
args: Vec<Expr>,
},
+ /// Returns whether the list contains the expr value.
+ InList {
+ /// The value to compare
+ expr: Box<Expr>,
+ /// The low end of the range
+ list: Vec<Expr>,
+ /// Whether the expression is negated
+ negated: bool,
Review comment:
I can't remember exactly, but I think there might be some semantic
difference (regarding NULLs, of course) in SQL between `c NOT IN (...)` and
`NOT c IN (...)` FWIW that might require representing them differnetly
##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -158,6 +158,15 @@ pub enum Expr {
/// List of expressions to feed to the functions as arguments
args: Vec<Expr>,
},
+ /// Returns whether the list contains the expr value.
+ InList {
+ /// The value to compare
+ expr: Box<Expr>,
+ /// The low end of the range
+ list: Vec<Expr>,
+ /// Whether the expression is negated
+ negated: bool,
Review comment:
I can't remember exactly, but I think there might be some semantic
difference (regarding NULLs, of course) in SQL between `c NOT IN (...)` and
`NOT c IN (...)` FWIW that might require representing them differently
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
