rok commented on code in PR #14341: URL: https://github.com/apache/arrow/pull/14341#discussion_r1297650296
########## cpp/src/parquet/encoding_test.cc: ########## @@ -874,7 +874,7 @@ std::shared_ptr<::arrow::Array> EncodingAdHocTyped<FLBAType>::GetValues(int seed } using EncodingAdHocTypedCases = - ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType, FLBAType>; + ::testing::Types<BooleanType, Int32Type, Int64Type, FloatType, DoubleType>; Review Comment: That's a good point. I reverted the `EncodingTraits<FLBAType>` change and expanded `ArrowBinaryHelper` to support `FLBA`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
