metesynnada commented on code in PR #7291:
URL: https://github.com/apache/arrow-datafusion/pull/7291#discussion_r1298541031
##########
datafusion/sql/src/parser.rs:
##########
@@ -213,11 +242,12 @@ impl fmt::Display for Statement {
Statement::CreateExternalTable(stmt) => write!(f, "{stmt}"),
Statement::DescribeTableStmt(_) => write!(f, "DESCRIBE TABLE ..."),
Statement::CopyTo(stmt) => write!(f, "{stmt}"),
+ Statement::Explain(stmt) => write!(f, "{stmt}"),
}
}
}
-/// DataFusion SQL Parser based on [`sqlparser`]
+/// Datafusion1 SQL Parser based on [`sqlparser`]
Review Comment:
```suggestion
/// Datafusion SQL Parser based on [`sqlparser`]
```
##########
datafusion/sql/src/statement.rs:
##########
@@ -706,13 +713,18 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
/// Generate a plan for EXPLAIN ... that will print out a plan
///
- fn explain_statement_to_plan(
+ /// Note this is the sqlparser explain statement, not the
+ /// datafusion `EXPLAIN` statement.
+ fn explain_to_plan(
&self,
verbose: bool,
analyze: bool,
- statement: Statement,
+ statement: DFStatement,
) -> Result<LogicalPlan> {
- let plan = self.sql_statement_to_plan(statement)?;
+ let plan = self.statement_to_plan(statement)?;
+ if matches!(plan, LogicalPlan::Explain(_)) {
+ return plan_err!("Nested explain not supported");
Review Comment:
Maybe the error can be `Nested EXPLAINs are not supported.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
