bkietz commented on code in PR #37040:
URL: https://github.com/apache/arrow/pull/37040#discussion_r1298581299
##########
cpp/src/arrow/device.h:
##########
@@ -165,6 +198,17 @@ class ARROW_EXPORT MemoryManager : public
std::enable_shared_from_this<MemoryMan
static Result<std::shared_ptr<Buffer>> ViewBuffer(
const std::shared_ptr<Buffer>& source, const
std::shared_ptr<MemoryManager>& to);
+ /// \brief Create a SyncEvent for exporting
+ ///
+ /// This version should construct the appropriate event for the device and
+ /// provide the unique_ptr with the correct deleter for the event type.
+ virtual Result<std::shared_ptr<Device::SyncEvent>> MakeDeviceSyncEvent();
+
+ /// \brief Create a SyncEvent from imported device array.
+ ///
+ /// @param sync_event passed in sync_event from the imported device array.
+ virtual Result<std::shared_ptr<Device::SyncEvent>>
MakeDeviceSyncEvent(std::unique_ptr<void, void(*)(void*)> sync_event);
Review Comment:
We don't need to wrap this into a unique_ptr *here*, it'll be less
boilerplate to wrap that in MakeDeviceSyncEvent.
```suggestion
/// \brief Create a SyncEvent from imported device array.
///
/// @param sync_event passed in sync_event from the imported device array.
/// @param release_sync_event destructor to free sync_event. `nullptr` may
/// be passed to indicate that no destruction is necessary.
virtual Result<std::shared_ptr<Device::SyncEvent>>
MakeDeviceSyncEvent(void *sync_event,
void release_sync_event(void*));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
