avantgardnerio commented on code in PR #7192:
URL: https://github.com/apache/arrow-datafusion/pull/7192#discussion_r1298652579
##########
datafusion/core/tests/sql/group_by.rs:
##########
@@ -68,6 +69,173 @@ async fn group_by_date_trunc() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn group_by_limit() -> Result<()> {
Review Comment:
I added some `sqllogictest`s.
I think we should keep this test though, because it asserts the `lim=[X]` is
present in the physical plan, which is the only way we can know for (almost?)
sure our optimized stream type is actually running. Its results should be
indistinguishable from the unoptimized version except for memory usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
