avantgardnerio commented on PR #7192: URL: https://github.com/apache/arrow-datafusion/pull/7192#issuecomment-1684178948
> Support non-String ID Hopefully we can do this in a follow-on PR > Remove SortOptions from HeapItem It was there because I misunderstood how MIN() and MAX() handle NULLs. > See if we can further reduce allocations - flamegraph[1] suggests a large part of the time in the aggregation is spent doing allocations both in btree and outside of it I would definitely like to do this, but in the next PR where we replace the `BTreeSet` entirely with a custom heap impl. > Misc cleanups I've addressed all the ones mentioned above. Please let me know if there are any others and I will handle those too,. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
