kou commented on code in PR #37255:
URL: https://github.com/apache/arrow/pull/37255#discussion_r1298852023
##########
python/pyarrow/_dataset_parquet.pyx:
##########
@@ -770,9 +771,12 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
other.thrift_container_size_limit)
return attrs == other_attrs
- @classmethod
- def _reconstruct(cls, kwargs):
- return cls(**kwargs)
+ @staticmethod
+ @binding(True) # Required for cython < 3
Review Comment:
```suggestion
@binding(True) # Required for Cython < 3
```
##########
python/pyarrow/tests/parquet/test_dataset.py:
##########
@@ -1557,20 +1557,10 @@ def is_pickleable(obj):
@pytest.mark.pandas
@parametrize_legacy_dataset
-def test_builtin_pickle_dataset(tempdir, datadir, use_legacy_dataset):
- import pickle
+def test_pickle_dataset(tempdir, datadir, use_legacy_dataset, pickle_module):
dataset = _make_dataset_for_pickling(tempdir, use_legacy_dataset)
_assert_dataset_is_picklable(
Review Comment:
Can we inline `_assert_dataset_is_picklable()` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
