nealrichardson commented on code in PR #37225:
URL: https://github.com/apache/arrow/pull/37225#discussion_r1299266432
##########
r/tools/nixlibs.R:
##########
@@ -197,7 +197,9 @@ compile_test_program <- function(code) {
# Note: if we wanted to check for openssl on macOS, we'd have to set the brew
# path as a -I directory. But since we (currently) only run this code to
# determine whether we can download a Linux binary, it's not relevant.
- runner <- "`R CMD config CXX17` `R CMD config CPPFLAGS` `R CMD config
CXX17FLAGS` `R CMD config CXX17STD` -E -xc++"
+ r_exec <- file.path(R.home("bin"), "R")
+ r_cmd <- paste0("`", r_exec, " CMD config ", c("CXX17", "CPPFLAGS",
"CXX17FLAGS", "CXX17STD"), "`", collapse = " ")
+ runner <- sprintf("%s -E -xc++", r_cmd)
Review Comment:
Following @kou's suggestion:
```suggestion
runner <- paste(
R_CMD_config("CXX17"),
R_CMD_config("CPPFLAGS"),
R_CMD_config("CXX17FLAGS"),
R_CMD_config("CXX17STD"),
"-E",
"-xc++"
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
