mapleFU commented on code in PR #36510:
URL: https://github.com/apache/arrow/pull/36510#discussion_r1299901798
##########
cpp/src/parquet/properties.cc:
##########
@@ -28,16 +28,20 @@
namespace parquet {
std::shared_ptr<ArrowInputStream> ReaderProperties::GetStream(
- std::shared_ptr<ArrowInputFile> source, int64_t start, int64_t num_bytes) {
- if (buffered_stream_enabled_) {
+ std::shared_ptr<ArrowInputFile> source, int64_t start, int64_t num_bytes,
+ std::optional<int64_t> custom_buffer_size) {
Review Comment:
Emmm why do we need a `custom_buffer_size` even when we already have a
`buffer_size` internal? This makes building a stream has "default buffer size",
"buffer size in ReaderProperties", "buffer size in GetStream"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
