mapleFU commented on PR #37275:
URL: https://github.com/apache/arrow/pull/37275#issuecomment-1686688157

   Before
   
   ```
   BM_ComputeHash<Int32Type>               33496 ns        33047 ns        
21239 items_per_second=495.785M/s
   BM_ComputeHash<Int64Type>               39656 ns        38217 ns        
18754 items_per_second=428.71M/s
   BM_ComputeHash<FloatType>               31851 ns        31729 ns        
21467 items_per_second=516.376M/s
   BM_ComputeHash<DoubleType>              38029 ns        37922 ns        
18432 items_per_second=432.042M/s
   BM_ComputeHash<ByteArrayType>           58705 ns        58625 ns        
11987 items_per_second=279.471M/s
   BM_ComputeHash<FLBAType>                53983 ns        53624 ns        
13022 items_per_second=305.537M/s
   BM_ComputeHash<Int96Type>               42545 ns        41847 ns        
16551 items_per_second=391.52M/s
   BM_BatchComputeHash<Int32Type>          16991 ns        16991 ns        
41152 items_per_second=964.288M/s
   BM_BatchComputeHash<Int64Type>          19473 ns        19473 ns        
35910 items_per_second=841.383M/s
   BM_BatchComputeHash<FloatType>          16978 ns        16978 ns        
41167 items_per_second=965.021M/s
   BM_BatchComputeHash<DoubleType>         19470 ns        19470 ns        
35928 items_per_second=841.498M/s
   BM_BatchComputeHash<ByteArrayType>      45086 ns        45086 ns        
15504 items_per_second=363.394M/s
   BM_BatchComputeHash<FLBAType>           44769 ns        44769 ns        
15627 items_per_second=365.967M/s
   BM_BatchComputeHash<Int96Type>          24302 ns        24302 ns        
28910 items_per_second=674.172M/s
   ```
   
   ```
   BM_ComputeHash<Int32Type>               31991 ns        31965 ns        
21962 items_per_second=512.558M/s
   BM_ComputeHash<Int64Type>               35487 ns        35473 ns        
19200 items_per_second=461.874M/s
   BM_ComputeHash<FloatType>               30803 ns        30795 ns        
22698 items_per_second=532.028M/s
   BM_ComputeHash<DoubleType>              36394 ns        36386 ns        
19212 items_per_second=450.284M/s
   BM_ComputeHash<ByteArrayType>           56184 ns        56171 ns        
12473 items_per_second=291.682M/s
   BM_ComputeHash<FLBAType>                51441 ns        51424 ns        
13726 items_per_second=318.609M/s
   BM_ComputeHash<Int96Type>               41537 ns        41495 ns        
16503 items_per_second=394.839M/s
   BM_BatchComputeHash<Int32Type>          17056 ns        17054 ns        
40914 items_per_second=960.687M/s
   BM_BatchComputeHash<Int64Type>          19548 ns        19547 ns        
35786 items_per_second=838.202M/s
   BM_BatchComputeHash<FloatType>          17062 ns        17061 ns        
41006 items_per_second=960.329M/s
   BM_BatchComputeHash<DoubleType>         19548 ns        19547 ns        
35854 items_per_second=838.187M/s
   BM_BatchComputeHash<ByteArrayType>      45999 ns        45983 ns        
15264 items_per_second=356.302M/s
   BM_BatchComputeHash<FLBAType>           45968 ns        45955 ns        
15225 items_per_second=356.523M/s
   BM_BatchComputeHash<Int96Type>          24277 ns        24273 ns        
28697 items_per_second=674.978M/s
   ```
   
   I've benchmark 3 times on my m1 macos, seems after this patch, `ComputeHash` 
would be a bit faster, and `BatchComputeHash` seems not have remarkable 
benifits. Maybe it's related to code cache or others


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to