nevi-me commented on a change in pull request #8988:
URL: https://github.com/apache/arrow/pull/8988#discussion_r550847402
##########
File path: rust/arrow/src/record_batch.rs
##########
@@ -75,6 +75,25 @@ impl RecordBatch {
/// # }
/// ```
pub fn try_new(schema: SchemaRef, columns: Vec<ArrayRef>) -> Result<Self> {
+ let options = RecordBatchOptions::default();
+ Self::validate_new_batch(&schema, columns.as_slice(), &options)?;
+ Ok(RecordBatch { schema, columns })
+ }
+
+ pub fn try_new_with_options(
Review comment:
@alamb @jorgecarleitao I must have done something wrong on the rebase, I
had added doc comments for this function, and added tests :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
