alamb commented on code in PR #7339:
URL: https://github.com/apache/arrow-datafusion/pull/7339#discussion_r1300525275
##########
datafusion/expr/src/built_in_function.rs:
##########
@@ -1395,25 +1395,25 @@ macro_rules! make_utf8_to_return_type {
DataType::LargeUtf8 => $largeUtf8Type,
DataType::Utf8 => $utf8Type,
DataType::Null => DataType::Null,
- DataType::Dictionary(_, value_type) => {
- match **value_type {
- DataType::LargeUtf8 => $largeUtf8Type,
- DataType::Utf8 => $utf8Type,
- DataType::Null => DataType::Null,
- _ => {
- // this error is internal as `data_types` should
have captured this.
- return internal_err!(
- "The {:?} function can only accept strings.",
- name
- );
- }
+ DataType::Dictionary(_, value_type) => match **value_type {
+ DataType::LargeUtf8 => $largeUtf8Type,
+ DataType::Utf8 => $utf8Type,
+ DataType::Null => DataType::Null,
+ _ => {
+ // this error is internal as `data_types` should have
captured this.
Review Comment:
this comment appears to be out of date. However, the code is good so I think
we can merge this PR in as is. Thank you @Weijun-H
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
