tustvold commented on code in PR #7351:
URL: https://github.com/apache/arrow-datafusion/pull/7351#discussion_r1300534606


##########
datafusion/common/src/scalar.rs:
##########
@@ -1781,6 +1782,25 @@ macro_rules! eq_array_primitive {
 }
 
 impl ScalarValue {
+    /// Create a [`ScalarValue`] with the provided value and datatype
+    ///
+    /// # Panics
+    ///
+    /// Panics if d is not compatible with T
+    pub fn new_primitive<T: ArrowPrimitiveType>(

Review Comment:
   This is the sort of thing that becomes so much simpler with #7353



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to