viirya commented on code in PR #7349:
URL: https://github.com/apache/arrow-datafusion/pull/7349#discussion_r1300539573


##########
datafusion/expr/src/type_coercion/binary.rs:
##########
@@ -680,6 +680,7 @@ pub fn like_coercion(lhs_type: &DataType, rhs_type: 
&DataType) -> Option<DataTyp
     string_coercion(lhs_type, rhs_type)
         .or_else(|| dictionary_coercion(lhs_type, rhs_type, false))
         .or_else(|| null_coercion(lhs_type, rhs_type))
+        .or_else(|| binary_coercion(lhs_type, rhs_type))

Review Comment:
   This coerces string to binary, but currently Like expr only works on string 
array. I saw you did a commit which adds binary support to Like but it was 
removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to