kou commented on code in PR #36739:
URL: https://github.com/apache/arrow/pull/36739#discussion_r1300658624
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -3346,7 +3346,11 @@ garrow_set_lookup_options_get_property(GObject *object,
g_value_set_object(value, priv->value_set);
break;
case PROP_SET_LOOKUP_OPTIONS_SKIP_NULLS:
- g_value_set_boolean(value, options->skip_nulls);
+ if (!options->skip_nulls.has_value() || !options->skip_nulls.value()) {
+ g_value_set_boolean(value, false);
+ } else {
+ g_value_set_boolean(value, true);
+ }
Review Comment:
```suggestion
g_value_set_boolean(value, options->skip_nulls.has_value() &&
options->skip_nulls.value());
```
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -6458,9 +6463,13 @@ garrow_set_lookup_options_new_raw(
arrow_copied_options.get());
auto value_set =
garrow_datum_new_raw(&(arrow_copied_set_lookup_options->value_set));
+ bool skip_nulls = false;
+ if (arrow_options->skip_nulls.has_value() &&
arrow_options->skip_nulls.value()) {
+ skip_nulls = true;
+ }
Review Comment:
```suggestion
auto skip_nulls = (arrow_options->skip_nulls.has_value() &&
arrow_options->skip_nulls.value());
```
##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -3398,13 +3402,14 @@
garrow_set_lookup_options_class_init(GArrowSetLookupOptionsClass *klass)
*
* Since: 6.0.0
*/
- spec = g_param_spec_boolean("skip-nulls",
- "Skip NULLs",
- "Whether NULLs are skipped or not",
- options.skip_nulls,
- static_cast<GParamFlags>(G_PARAM_READWRITE));
- g_object_class_install_property(gobject_class,
- PROP_SET_LOOKUP_OPTIONS_SKIP_NULLS,
+ bool skip_nulls = false;
+ if (options.skip_nulls.has_value() && options.skip_nulls.value()) {
+ skip_nulls = true;
+ }
Review Comment:
```suggestion
auto skip_nulls = (options.skip_nulls.has_value() &&
options.skip_nulls.value());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
