tustvold commented on code in PR #7358:
URL: https://github.com/apache/arrow-datafusion/pull/7358#discussion_r1300746094
##########
datafusion/physical-expr/src/aggregate/average.rs:
##########
@@ -493,104 +569,111 @@ mod tests {
use super::*;
use crate::expressions::col;
use crate::expressions::tests::aggregate;
- use crate::generic_test_op;
use arrow::record_batch::RecordBatch;
use arrow::{array::*, datatypes::*};
- use datafusion_common::Result;
+ use datafusion_expr::aggregate_function::sum_type_of_avg;
+ use datafusion_expr::type_coercion::aggregates::avg_return_type;
+
+ fn test_with_pre_cast(array: ArrayRef, expected: ScalarValue) {
Review Comment:
This change is necessary because generic_test_op would call Avg::new which
would then not have the correct arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
