R-JunmingChen commented on code in PR #37100:
URL: https://github.com/apache/arrow/pull/37100#discussion_r1300778191
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -492,11 +492,24 @@ Result<std::unique_ptr<KernelState>>
MinMaxInit(KernelContext* ctx,
return visitor.Create();
}
+namespace {
+
+Result<TypeHolder> DictionaryValueType(KernelContext*,
+ const std::vector<TypeHolder>& types) {
+ // T -> T.value_type
+ auto ty = types.front();
+ const DictionaryType& ty_dict = checked_cast<const DictionaryType&>(*ty);
+ return ty_dict.value_type();
+}
+
+} // namespace
+
// For "min" and "max" functions: override finalize and return the actual value
template <MinOrMax min_or_max>
-void AddMinOrMaxAggKernel(ScalarAggregateFunction* func,
- ScalarAggregateFunction* min_max_func) {
- auto sig = KernelSignature::Make({InputType::Any()}, FirstType);
+void AddMinOrMaxAggKernels(ScalarAggregateFunction* func,
+ ScalarAggregateFunction* min_max_func) {
+ std::shared_ptr<arrow::compute::KernelSignature> sig =
+ KernelSignature::Make({InputType::Any()}, FirstType);
Review Comment:
It seems TypeMatcher can do this, let me implement it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
